inflight.js ➔ makeres - Code Metrics - LukasMeine/vigilance - Measure and Improve Code Quality continuously with Scrutinizer

inflight.js ➔ makeres A
last analyzed 2018-08-02 16:14 UTC

↳ Parent: node_modules/inflight/inflight.js

Complexity

Conditions	1
Paths	1

Size

Total Lines	30
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	15
nc	1
nop	1
dl	0
loc	30
rs	9.65
c	0
b	0
f	0

1 Function

Rating	Name	Duplication	Size	Complexity
A	inflight.js ➔ ... ➔ RES	0	28	3

var wrappy = require('wrappy')
var reqs = Object.create(null)
var once = require('once')

module.exports = wrappy(inflight)

function inflight (key, cb) {
  if (reqs[key]) {
    reqs[key].push(cb)
    return null
  } else {

    reqs[key] = [cb]
    return makeres(key)
  }
}

function makeres (key) {
  return once(function RES () {
    var cbs = reqs[key]
    var len = cbs.length
    var args = slice(arguments)

    // XXX It's somewhat ambiguous whether a new callback added in this
    // pass should be queued for later execution if something in the
    // list of callbacks throws, or if it should just be discarded.
    // However, it's such an edge case that it hardly matters, and either
    // choice is likely as surprising as the other.
    // As it happens, we do go ahead and schedule it for later execution.
    try {
      for (var i = 0; i < len; i++) {
        cbs[i].apply(null, args)
      }
    } finally {
      if (cbs.length > len) {
        // added more in the interim.
        // de-zalgo, just in case, but don't call again.
        cbs.splice(0, len)
        process.nextTick(function () {
          RES.apply(null, args)
        })
      } else {
        delete reqs[key]
      }
    }
  })
}

function slice (args) {
  var length = args.length
  var array = []

  for (var i = 0; i < length; i++) array[i] = args[i]
if (a > 0)
    b = 42;
  return array
}


1			var wrappy = require('wrappy')
2			var reqs = Object.create(null)
3			var once = require('once')
4
5			module.exports = wrappy(inflight)
6
7			function inflight (key, cb) {
8			if (reqs[key]) {
9			reqs[key].push(cb)
10			return null
11			} else {
			0 ignored issues – show Comprehensibility introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report `else` is not necessary here since all `if` branches return, consider removing it to reduce nesting and make code more readable. Loading history...
12			reqs[key] = [cb]
13			return makeres(key)
14			}
15			}
16
17			function makeres (key) {
18			return once(function RES () {
19			var cbs = reqs[key]
20			var len = cbs.length
21			var args = slice(arguments)
22
23			// XXX It's somewhat ambiguous whether a new callback added in this
24			// pass should be queued for later execution if something in the
25			// list of callbacks throws, or if it should just be discarded.
26			// However, it's such an edge case that it hardly matters, and either
27			// choice is likely as surprising as the other.
28			// As it happens, we do go ahead and schedule it for later execution.
29			try {
30			for (var i = 0; i < len; i++) {
31			cbs[i].apply(null, args)
32			}
33			} finally {
34			if (cbs.length > len) {
35			// added more in the interim.
36			// de-zalgo, just in case, but don't call again.
37			cbs.splice(0, len)
38			process.nextTick(function () {
39			RES.apply(null, args)
40			})
41			} else {
42			delete reqs[key]
43			}
44			}
45			})
46			}
47
48			function slice (args) {
49			var length = args.length
50			var array = []
51
52			for (var i = 0; i < length; i++) array[i] = args[i]
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
53			return array
54			}
55

LukasMeine / vigilance

inflight.js ➔ makeres A last analyzed 2018-08-02 16:14 UTC

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like

inflight.js ➔ makeres A
last analyzed 2018-08-02 16:14 UTC